Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle missing entries (fixes #1236) #1253

Merged
merged 2 commits into from
Sep 26, 2023
Merged

handle missing entries (fixes #1236) #1253

merged 2 commits into from
Sep 26, 2023

Conversation

conradludgate
Copy link
Collaborator

atuin history end errors if the ID doesn't exist. This can happen if the user changes their database setting mid-command.

Fix: ignore these errors, and log a warning.
Additional: Removes all potential missing entry database queries and handles the options appropriately

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
atuin-docs ✅ Ready (Inspect) Visit Preview Sep 25, 2023 10:58am

@conradludgate conradludgate requested a review from ellie September 26, 2023 12:58
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@conradludgate conradludgate merged commit fc1a48a into main Sep 26, 2023
9 checks passed
@conradludgate conradludgate deleted the missing-entries branch September 26, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants