Fix invoking application mode after leaving it (Fixes #650) #1149
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is what I tested locally and it solved the problem for me but I wasn't sure whether it'd cause issues elsewhere. The comment Either way, if this PR is ok, the comment should be removed/updated so they're not out of sync. |
I'll have to double check before merging this. I remember there were issues with certain keycodes not being recognized in application mode, but that's probably been resolved by now. (also... can't believe it's been >2yrs 😭) |
This was initially in place for when we used a different terminal backend. That backend required that the terminal be in a specific mode, or otherwise key modifiers would not be correctly recognized. It was super frustrating. Since the move to crossterm, we automatically switch to raw mode: https://github.com/atuinsh/atuin/blob/b48de9bd9d89fb9b6a0044a1b251e5b2ff116387/atuin/src/command/client/search/interactive.rs#L528 Should resolve #987, #650, #909, #492 Should also supercede #1149
This was initially in place for when we used a different terminal backend. That backend required that the terminal be in a specific mode, or otherwise key modifiers would not be correctly recognized. It was super frustrating. Since the move to crossterm, we automatically switch to raw mode: https://github.com/atuinsh/atuin/blob/b48de9bd9d89fb9b6a0044a1b251e5b2ff116387/atuin/src/command/client/search/interactive.rs#L528 Should resolve #987, #650, #909, #492 Should also supercede #1149
|
Hey! I looked into this this morning, and I don't think we actually need the mode switching any more. I've removed it in #1170 |
According to terminfo:
smkx is enter application mode and rmkx is leave back to normal mode
Thanks @tpoliaw