Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ubuntu/arm*): detect non amd64 ubuntu and handle #1131

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

jinnko
Copy link
Contributor

@jinnko jinnko commented Jul 28, 2023

If we're running Ubuntu on non-amd64 we get an install error. As there's no ARM package yet we can offer the user the option to install via cargo rather than install something that won't work.

@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2023 7:31pm

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

ellie
ellie previously approved these changes Jul 30, 2023
If we're running Ubuntu on non-amd64 we get an install error.  As there's
no ARM package yet we can offer the user the option to install via cargo
rather than install something that won't work.
@jinnko
Copy link
Contributor Author

jinnko commented Aug 4, 2023

@ellie - I've updated this PR to include the org name change that was made.

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry it took me so long to circle back on the review 🙃

I'd like to build debs for ARM at some point, seeing as we build binaries for ARM now

@ellie ellie enabled auto-merge (squash) August 17, 2023 20:43
@ellie ellie merged commit fbbe24d into atuinsh:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants