Check if OLDPWD variable is overriden while executing 'cd -' #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksh does not check if OLDPWD variable is overriden while going to previous directory through 'cd -'. For e.g. OLDPWD=/bin ksh -c 'OLDPWD=/tmp cd -' takes to '/bin' directory. This commit fixes it. Resolves: #8
krader1961
reviewed
Mar 21, 2018
src/cmd/ksh93/tests/builtins.sh
Outdated
| @@ -896,6 +896,8 @@ else | |||
| err_exit 'cannot cd to ~{fd} when fd is /dev' | |||
| fi | |||
|
|
|||
| mkdir $tmp/oldpwd | |||
| [[ $(OLDPWD="$tmp/oldpwd" cd -) == "$tmp/oldpwd" ]] || err_exit "cd - does not recognize overriden OLDPWD variable" | |||
There was a problem hiding this comment.
Thx for adding a test. However, the wording of the error isn't quite correct. In fact, it's probably worth adding a related test:
cd /
OLDPWD=$tmp/oldpwd
cd -
[[ $PWD == "$tmp/oldpwd" ]] || err_exit "cd - does not recognize overridden OLDPWD variable"
That's because overriding OLDPWD does work but not if done by creating a new env context. The above test should pass without this fix.
Also, s/overriden/overridden/
There was a problem hiding this comment.
I have added the test case that you suggested.
|
LGTM |
Add test cases to check if overriden OLDPWD variable is recognized while executing 'cd -'. Related: #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #8