ksh93 echoing wrong output due to missing EIO handling during logout #30
Comments
lijog
changed the title
lijog
changed the title
|
I missed out the changes in the error.h include file earlier. --- INIT.2012-08-01.old/src/cmd/ksh93/sh/io.c 2017-01-04 14:41:25.199402375 +0000 #ifndef ERROR_PIPE --- INIT.2012-08-01.old/src/lib/libast/include/error.h 2017-02-17 02:39:37.507460057 +0000 #ifdef ECONNRESET /* |
Patch originally from Solaris, fixes att#30
Patch originally from Solaris, fixes att#30
Patch originally from Solaris, fixes att#30
Patch originally from Solaris, fixes att#30
Patch originally from Solaris, fixes att#30
Patch originally from Solaris, fixes att#30
Patch originally from Solaris, fixes att#30
Patch originally from Solaris, fixes att#30
This change is pulled from here: https://github.com/oracle/solaris-userland/blob/master/components/ksh93/patches/275-20855453.patch att#30 George Lijo wrote on 17 Feb 2017: > Here's a reproducible testcase on a Solaris11 host running > ksh93u+(2012-08-01). > $ cat a.sh > #!/bin/sh > > AAA="aaa" > echo 'insert character' > BBB=`echo ${AAA} | sed "s/aaa/bbb/g"` > logger "variable BBB = ${BBB}" > > $ cat t.sh > #!/bin/ksh > > sleep 10 > /bin/ksh ./a.sh > exit 0 > > $ > > $ ./t.sh > > The expected result is: > > Apr 9 12:43:34 lab user: [ID 702911 user.notice] variable BBB = bbb > > because variable "BBB" is supposed to be set to 'bbb' in a.sh. > > But if the parent shell is terminated, the variable is wrongly set. > > user@xxxxx$ telnet lab > ... > $ ./t.sh & <--- Run t.sh in background. > [1] 2067 > $ logout <--- CTRL + D to exit while t.sh is running. > Connection to lab closed by foreign host. > > Again, access the system and check the output: > > user@xxxxx$ telnet lab > ... > $ tail -f /var/adm/messages > : > Apr 9 12:47:47 lab user: [ID 702911 user.notice] variable BBB = > insert character <--- !!! > Apr 9 12:47:47 lab bbb > <--- !!! > > Thus the variable is wrongly set. (The previous echo string was > not cleared.) > > The issue happens because the EIO error during the logout is not > handled properly. src/cmd/ksh93/sh/io.c, src/lib/libast/include/error.h: - Amend the ERROR_PIPE() macro to check for EIO as well as EPIPE and ECONNRESET.
Patch originally from Solaris, fixes att#30
After making PATH readonly in a virtual subshell (without otherwise changing it, so the subshell is never forked), then the main shell would erroneously fork into a background process immediately after leaving the virtual subshell. This was caused by a bug in the forking workaround that prevents changes in PATH in a virtual subshell from clearing the parent shell's hash table. src/cmd/ksh93/sh/name.c: nv_putval(): - If we're either setting or restoring PATH, do an additional check for the NV_RDONLY flag, which means the function was told to ignore the variable's readonly state. It is told to ignore that when restoring the parent shell state after exiting a virtual subshell. If we don't fork then, we don't fork the parent shell. src/cmd/ksh93/tests/subshell.sh: - Add regression test verifying that no forking happens when making PATH readonly in a subshell. Fixes att#30.
Here's a reproducible testcase on a Solaris11 host running ksh93u+(2012-08-01).
$ cat a.sh
#!/bin/sh
AAA="aaa"
echo 'insert character'
BBB=
echo ${AAA} | sed "s/aaa/bbb/g"logger "variable BBB = ${BBB}"
$ cat t.sh
#!/bin/ksh
sleep 10
/bin/ksh ./a.sh
exit 0
$
$ ./t.sh
The expected result is:
Apr 9 12:43:34 lab user: [ID 702911 user.notice] variable BBB = bbb
because variable "BBB" is supposed to be set to 'bbb' in a.sh.
But if the parent shell is terminated, the variable is wrongly set.
user@xxxxx$ telnet lab
...
$ ./t.sh & <--- Run t.sh in background.
[1] 2067
$ logout <--- CTRL + D to exit while t.sh is running.
Connection to lab closed by foreign host.
Again, access the system and check the output:
user@xxxxx$ telnet lab
...
$ tail -f /var/adm/messages
:
Apr 9 12:47:47 lab user: [ID 702911 user.notice] variable BBB = insert
character <--- !!!
Apr 9 12:47:47 lab bbb
<--- !!!
Thus the variable is wrongly set. (The previous echo string was not cleared.)
The issue happens because the EIO error during the logout is not handled properly.
The following patch fixes the issue
--- INIT.2012-08-01.old/src/cmd/ksh93/sh/io.c 2017-01-04 14:41:25.199402375 +0000
+++ INIT.2012-08-01/src/cmd/ksh93/sh/io.c 2017-01-04 14:32:20.279449987 +0000
@@ -64,9 +64,9 @@
#ifndef ERROR_PIPE
#ifdef ECONNRESET
-#define ERROR_PIPE(e) ((e)==EPIPE||(e)==ECONNRESET)
+#define ERROR_PIPE(e) ((e)==EPIPE||(e)==ECONNRESET||(e)==EIO)
#else
-#define ERROR_PIPE(e) ((e)==EPIPE)
+#define ERROR_PIPE(e) ((e)==EPIPE||(e)==EIO)
#endif
#endif
The text was updated successfully, but these errors were encountered: