Skip to content

Commit

Permalink
Bump to xamarin-android-api-compatibility/master/2c689ef2
Browse files Browse the repository at this point in the history
Fixes: dotnet#1089

We found that xamarin-android-api-compatibility wasn't *actually*
performing the inter-API-level checks, meaning an important API
compatibility check wasn't being performed.

Bump to xamarin-android-api-compatibility/2c689ef2 so that
inter-API-level checks are properly performed.

Additionally, set `$(HTML_OUTPUT_DIR)` so that `mono-api-html` output
files are written into `bin/Build$(CONFIGURATION)/compatibility`.
This will (hopefully) allow us to use the Jenkins
**Publish HTML reports** Post-build Action to nicely display API
compatibility breakage, without requiring that we read the actual
build log output.
  • Loading branch information
jonpryor authored and atsushieno committed Feb 22, 2018
1 parent b1ce544 commit eb7ad74
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
[submodule "external/xamarin-android-api-compatibility"]
path = external/xamarin-android-api-compatibility
url = https://github.com/xamarin/xamarin-android-api-compatibility.git
branch = d15-7
branch = master
[submodule "external/xamarin-android-tools"]
path = external/xamarin-android-tools
url = https://github.com/xamarin/xamarin-android-tools
Expand Down
2 changes: 2 additions & 0 deletions tests/api-compatibility/api-compatibility.mk
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ FRAMEWORK_DIR = bin/$(CONFIGURATION)/lib/xamarin.android/xbuild-frameworks/M


run-api-compatibility-tests: $(MONO_API_HTML) $(MONO_API_INFO)
mkdir -p bin/Build$(CONFIGURATION)/compatibility
make -C external/xamarin-android-api-compatibility check \
MONO_API_HTML="$(RUNTIME) $(abspath $(MONO_API_HTML))" \
MONO_API_INFO="$(RUNTIME) $(abspath $(MONO_API_INFO))" \
HTML_OUTPUT_DIR="$(abspath bin/Build$(CONFIGURATION)/compatibility)" \
XA_FRAMEWORK_DIR="$(abspath $(FRAMEWORK_DIR))"

$(MONO_API_HTML): $(wildcard $(MONO_API_HTML_DIR)/*.cs) $(MONO_OPTIONS_SRC)
Expand Down

0 comments on commit eb7ad74

Please sign in to comment.