fix: Fix the regular expression for the daemon's notification subscription #1557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
fix: Fix the regular expression for the daemon's notification subscription so if device name is 'xyz' then it will handle notifications to 'ping.xyz.sshnp' or 'xyz.sshnp' but not to 'ping.wxyz' or 'wxyz.sshnp'
Fixes #1485
- How I did it
See commits
- How to verify it
xyz
and another with device namewxyz
wxyz
sshnpd
from releases up to now, both daemons will receive the request; and if they are using policy then both will send a request to the policy server. (Note that, ultimately, the daemon forxyz
will not actually try to handle the request, which is why this bug has slipped through the net until now)sshnpd
built from this branch, the request will only be received by the intended recipient daemon.