Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Better defaults for sshnpd's --permit-open #1353

Merged
merged 1 commit into from
Sep 16, 2024
Merged

feat: Better defaults for sshnpd's --permit-open #1353

merged 1 commit into from
Sep 16, 2024

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Sep 16, 2024

- What I did

- How I did it

- How to verify it
Tests pass

@gkc
feat: resolves #1295
1fe6b34 
- added logic in SshnpdParams for dealing with permitOpen in the specific situation described in #1295
- added the permitOpen default to SshnpdDefaultArgs
- added unit tests
@gkc gkc requested a review from XavierChanth September 16, 2024 11:50
@gkc gkc merged commit 17fda8e into trunk Sep 16, 2024
8 checks passed
@gkc gkc deleted the fix-1295 branch September 16, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierChanth XavierChanth XavierChanth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better defaults for sshnpd's --permit-open
2 participants
@gkc @XavierChanth