fix: npt atSign handling #1332
Merged
fix: npt atSign handling #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: dart format
…atSign args if missing; better to be explicit and make the args parsing fail
XavierChanth
requested changes
Sep 11, 2024
Yes this is technically a breaking change re the noports programs - however, atSigns may only ever include lowercase, so this should never break anyone's installation. Nevertheless I'll remove the strict validation and just do the coercion to lowercase silently. |
…t's a breaking change (albeit, atSigns will never actually include uppercase)
XavierChanth
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
--list-deviceswhich should allow blank daemon and relay atSigns- How to verify it
Tests pass