Improve the bsp_pins! macro #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the changes proposed in atsamd-rs#475. Closes atsamd-rs#475
TDHolmes
reviewed
Oct 9, 2021
|
This is awesome. I'll be honest, I only focused on the documentation (my macro game is nigh non-existent), but the functionality here seems super useful |
|
I made a very small improvement to the docs and I merged in |
TDHolmes
approved these changes
Oct 11, 2021
|
oh wait, @bradleyharden update the changelog 😬 |
TDHolmes
requested changes
Oct 16, 2021
TDHolmes
reviewed
Oct 16, 2021
kaizensparc
pushed a commit
to kaizensparc/atsamd
that referenced
this pull request
Dec 24, 2021
* Improve the bsp_pins! macro Implement the changes proposed in atsamd-rs#475. Closes atsamd-rs#475 * Fix typo Co-authored-by: Tyler Holmes <[email protected]> * fixup! Merge branch 'master' into improve_bsp_pins * Add entry to changelog Co-authored-by: Tyler Holmes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the changes proposed in #475.
Closes #475