Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build on GCC13 #20

Merged
merged 1 commit into from
May 13, 2023
Merged

Conversation

NicolasDerumigny
Copy link

Building with GCC13.1.1 does not finish and crashed with error:

../../../../../submodules/qemu/tcg/plugins/cpp/coverage.cpp: In member function ‘void plugin_coverage::dump_symbol_coverage(symbol&, std::unordered_map<long unsigned int, long unsigned int>&)’:
../../../../../submodules/qemu/tcg/plugins/cpp/coverage.cpp:77:32: error: possibly dangling reference to a temporary [-Werror=dangling-reference]
   77 |             const instruction& i = get_instruction(i_pc, std::move(cs_inst));
      |                                ^
../../../../../submodules/qemu/tcg/plugins/cpp/coverage.cpp:77:51: note: the temporary was destroyed at the end of the full expression ‘plugin::get_instruction(i_pc, std::unique_ptr<cs_insn, void (*)(cs_insn*)>((* & std::move<unique_ptr<cs_insn, void (*)(cs_insn*)>&>(cs_inst))))’
   77 |             const instruction& i = get_instruction(i_pc, std::move(cs_inst));
      |                                    ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
ninja: build stopped: subcommand failed.

This fixes the issue.

@github-actions
Copy link

Thank you for your interest in the QEMU project.

This repository is a read-only mirror of the project's repostories hosted
on https://gitlab.com/qemu-project/qemu.git.
The project does not process merge requests filed on GitHub.

QEMU welcomes contributions of code (either fixing bugs or adding new
functionality). However, we get a lot of patches, and so we have some
guidelines about contributing on the project website:
https://www.qemu.org/contribute/

@github-actions github-actions bot closed this May 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2023
@guillon guillon reopened this May 13, 2023
@guillon guillon merged commit d3f323a into atos-tools:next/master May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants