Add tests for R/messages.R
#89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@averissimo no rush - can fix merge conflicts when you have a second please |
averissimo
force-pushed
the
82-messages-expand_test_suite
branch
from
bc7f327 to
af72bf2
Compare
averissimo
changed the base branch from
devel
to
82-xportr_length-expand_test_suite
|
@bms63 I've resolved the conflicts and integrated some of the changes from PR #88 (via rebase). As such, this PR no longer uses So this PR will either merge to that branch or to |
bms63
reviewed
Apr 28, 2023
| @@ -135,16 +150,13 @@ label_log <- function(miss_vars, verbose) { | |||
| #' @export | |||
| var_ord_msg <- function(moved_vars, verbose) { | |||
|
|
|||
| if (moved_vars > 0) { | |||
| if (length(moved_vars) > 0) { | |||
bms63
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
(edit) ℹ️ base branch changed to
82-xportr_length-expand_test_suiteChanges description
var_ord_msg()call that was not checking the length of the vectormessage()withxportr_logger()glue)R/messages.Rfilemockerydependency to Suggests (optional, but nice to have as it allows to cleanup test output by mockingcli_*()functions)test/testthat/helper-mock_bindings.Rhelper files to contain function re-used in test