Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test cases for label functions and fix existing test warnings #87

Merged
merged 12 commits into from
Apr 28, 2023
Merged

Adding test cases for label functions and fix existing test warnings #87

merged 12 commits into from
Apr 28, 2023

Conversation

vedhav
Copy link
Collaborator

@vedhav vedhav commented Apr 19, 2023 •
edited
Loading

Partially addresses #82

Changes made:

  1. Added test cases to cover the xportr_df_label() from the df_label.R file
  2. Added test cases to cover the xportr_label() from the label.R file
  3. Wrapped as.list() around a map function to suppress deprecation warning from purrr
  4. Fixed the commented test by removing the regex filter. So, now it works as expected.
  5. Added metacore package as Suggests because we are starting to use it in tests, and soon we will use it in the examples.

I have not yet added the metacore package to the renv.lock Do we even need a renv.lock for this package? I feel just the DESCRIPTION file should be enough WDYT?

@vedhav vedhav requested review from elimillera and bms63 April 19, 2023 00:25
@averissimo averissimo mentioned this pull request Apr 19, 2023
Merged
elimillera
elimillera requested changes Apr 21, 2023
View reviewed changes
@bms63
Copy link
Collaborator

bms63 commented Apr 25, 2023

skip_if metacore is not available on CRAN.

@averissimo averissimo linked an issue Apr 26, 2023 that may be closed by this pull request
Increase unit test coverage to over 80% #82
Closed
@vedhav vedhav requested a review from bms63 April 27, 2023 16:44
bms63
bms63 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@bms63 bms63 merged commit d217dec into devel Apr 28, 2023
@bms63 bms63 deleted the 82.vedha-add-tests-for-label-functions branch April 28, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elimillera elimillera elimillera requested changes

@bms63 bms63 bms63 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase unit test coverage to over 80%
3 participants
@vedhav @bms63 @elimillera