Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Q: Can all or any of the Suggested packages be removed? #221

Closed
averissimo opened this issue Jan 17, 2024 · 2 comments · Fixed by #229
Closed

Q: Can all or any of the Suggested packages be removed? #221

averissimo opened this issue Jan 17, 2024 · 2 comments · Fixed by #229
Assignees
@averissimo

Comments

@averissimo
Copy link
Collaborator

Thinking about:

  • {devtools}
  • {lintr}
  • {spelling}
  • {usethis}
    • only 1 mention on documentation
@bms63
Copy link
Collaborator

bms63 commented Jan 17, 2024

I think some of our workflows makes use of these packages?

image

We could rebuild the workflows and just manually install them in the workflow and remove from the Suggest. WDYT?

@averissimo averissimo self-assigned this Jan 18, 2024
@averissimo
Copy link
Collaborator Author

Yes, I think that would be a nice solution.

@averissimo averissimo mentioned this issue Jan 30, 2024
Merged
14 tasks
bms63 added a commit that referenced this issue Feb 14, 2024
@bms63
chore: #221 update spelling
e4c6e72
bms63 added a commit that referenced this issue Feb 14, 2024
@bms63
Merge pull request #229 from atorus-research/221-dependency-cleanup
b13dada 
Closes #221 Removes suggested packages and update CI actions
averissimo added a commit that referenced this issue Feb 15, 2024
@averissimo
Merge remote-tracking branch 'origin/main' into 219-withr
4467be6 
* origin/main: (199 commits)
  [skip actions] Bump version to 0.3.1.9018
  corrects typo
  chore: #221 update spelling
  ci: remove admiral string that was helping identifying action on UI
  revert deliberate errors
  Trigger CI
  ci: reusing workflows from admiralci
  [skip actions] Bump version to 0.3.1.9017
  [skip actions] Bump version to 0.3.1.9016
  Update pull_request_template.md
  chore: removed duplicated documentation section in news
  chore: breaking news - turn to channel 6!
  docs: #192 remove non-user functions from reference files
  docs: #230 #188 PR template tweaks
  [skip actions] Bump version to 0.3.1.9015
  lint:reduce lenght of line
  Reduce line length less than 120 characters
  Update NEWS.md
  change argument name to length_source
  Change argument name to source_length in test-length
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@averissimo averissimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #221 Removes suggested packages and update CI actions atorus-research/xportr
2 participants
@averissimo @bms63