fix addrow!+ test (#27)

* unrestrict type of matrix elements * fix addrow!' * more test * bump version
atoptima · Oct 6, 2021 · db80549 · db80549 · guimarqu · Oct 6, 2021
1 parent 12f1d92
commit db80549
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "DynamicSparseArrays"
 uuid = "8086fd22-9a0c-46a5-a6c8-6e24676501fe"
 authors = ["Guillaume Marques <[email protected]>"]
-version = "0.5.0"
+version = "0.5.1"
 
 [compat]
 julia = "1"

diff --git a/src/matrix.jl b/src/matrix.jl
@@ -77,7 +77,7 @@ function addrow!(
         addrow!(matrix.buffer, row, colids, vals)
     else
         for j in 1:length(colids)
-            setindex!(matrix, row, colids[j], vals[j])
+            setindex!(matrix, vals[j], row, colids[j])
         end
     end
     return true

diff --git a/test/functional/sparsematrix.jl b/test/functional/sparsematrix.jl
@@ -449,6 +449,16 @@ function dynsparsematrix_fill_mode()
         @test matrix.rowmajor[j, i] == values[i, j]
     end
 
+    # Try addrow! when fill mode off
+    row_id = 7
+    row_cols = [1, 3, 4, 5]
+    row_vals = [2, 3, 6, 7]
+    addrow!(matrix, row_id, row_cols, row_vals)
+
+    for (k,j) in enumerate(row_cols)
+        @test matrix[row_id,j] == row_vals[k] 
+    end
+
     ## Second test
     row = rand(rng, 1:1000, 10_000)
     col = rand(rng, 1:1000, 10_000)