Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Benders flow for infeasible/unbounded #939

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Conversation

najaverzat
Copy link
Contributor

Two tests in benders_flow.jl

  • benders_flow_unbounded_master ; I check that we enter treat_unbounded_master_problem_case! method, the test passed
  • benders_flow_infeasible_sp ; I create a formulation with some 1st level variables fixed so that the sp is infeasible. I was expected to enter treat_infeasible_separation_problem_case! but this is not the case. But maybe it is not the expected behaviour given my formulation ?

@guimarqu guimarqu changed the title Begin to test Benders flow Test Benders flow Jun 19, 2023
@guimarqu guimarqu changed the title Test Benders flow Test Benders flow for infeasible/unbounded Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.23 🎉

Comparison is base (eb8d73d) 78.10% compared to head (a5f28a2) 78.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
+ Coverage   78.10%   78.34%   +0.23%     
==========================================
  Files          83       83              
  Lines        5882     5882              
==========================================
+ Hits         4594     4608      +14     
+ Misses       1288     1274      -14     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@guimarqu guimarqu merged commit e9bc978 into master Jun 19, 2023
@guimarqu guimarqu deleted the test_benders_flow branch June 19, 2023 12:38
@@ -152,11 +147,12 @@ function benders_infeasible_sp()
for (_, sp) in Coluna.MathProg.get_benders_sep_sps(reform)
sp.optimizers = Coluna.MathProg.AbstractOptimizer[] # dirty
ClMP.push_optimizer!(sp, () -> ClA.MoiOptimizer(GLPK.Optimizer()))
Coluna.Algorithm._deactivate_art_vars(sp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @enjoyUrFruits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants