Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Benders algorithm logic #911

Merged
merged 2 commits into from
May 27, 2023
Merged

fix Benders algorithm logic #911

merged 2 commits into from
May 27, 2023

Conversation

guimarqu
Copy link
Contributor

@guimarqu guimarqu commented May 26, 2023

Transitions between different first-stage MILP and second-stage LPs were not correct when the original problem is unbounded. This is now fixed.

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch coverage: 72.22% and project coverage change: +0.33 🎉

Comparison is base (00f3bda) 69.10% compared to head (14e976e) 69.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
+ Coverage   69.10%   69.44%   +0.33%     
==========================================
  Files          82       82              
  Lines        5882     5940      +58     
==========================================
+ Hits         4065     4125      +60     
+ Misses       1817     1815       -2     
Impacted Files Coverage Δ
src/Algorithm/benders/printer.jl 45.19% <15.38%> (+45.19%) ⬆️
src/Benders/Benders.jl 61.53% <73.33%> (+2.27%) ⬆️
src/Algorithm/benders/default.jl 81.81% <94.02%> (-6.47%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@guimarqu guimarqu merged commit 70aa230 into master May 27, 2023
@guimarqu guimarqu deleted the benders_refact_745806 branch May 27, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant