Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advanced-demo review #904

Merged
merged 1 commit into from
May 16, 2023
Merged

advanced-demo review #904

merged 1 commit into from
May 16, 2023

Conversation

najaverzat
Copy link
Contributor

Remarks:

  • line 782: is the verb "convexify" a real word ?
  • both "subproblem" and "sub-problem" are used in the demo, it is the same for "preprocessing" and "pre-processing". To me both writings are correct but we may choose one of them and keep it for the entire file.

@najaverzat najaverzat requested a review from guimarqu May 16, 2023 09:08
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.81 ⚠️

Comparison is base (59f1508) 69.10% compared to head (64396a6) 68.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
- Coverage   69.10%   68.30%   -0.81%     
==========================================
  Files          82       78       -4     
  Lines        5882     5521     -361     
==========================================
- Hits         4065     3771     -294     
+ Misses       1817     1750      -67     

see 62 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@guimarqu guimarqu merged commit 8219476 into master May 16, 2023
@guimarqu guimarqu deleted the review-tuto branch May 16, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants