Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnGeneration phase one #86

Merged
merged 6 commits into from
May 22, 2019
Merged

ColumnGeneration phase one #86

merged 6 commits into from
May 22, 2019

Conversation

vitornesello
Copy link
Collaborator

Fix issue #43

@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

Merging #86 into master will increase coverage by 0.29%.
The diff coverage is 90.24%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #86      +/-   ##
=========================================
+ Coverage    91.5%   91.8%   +0.29%     
=========================================
  Files          33      33              
  Lines        1472    1501      +29     
=========================================
+ Hits         1347    1378      +31     
+ Misses        125     123       -2
Impacted Files Coverage Δ
src/incumbents.jl 87.17% <100%> (+0.69%) ⬆️
src/node.jl 93.26% <100%> (+0.06%) ⬆️
src/algorithms/reformulationsolver.jl 93.33% <100%> (ø) ⬆️
src/strategies/conquer/simplebnp.jl 100% <100%> (ø) ⬆️
src/algorithms/colgen.jl 93.33% <87.5%> (+1.44%) ⬆️
src/algorithms/generatechildrennodes.jl 100% <0%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7532940...b5b4139. Read the comment docs.

@vitornesello vitornesello changed the title WIP: ColumnGeneration phase one ColumnGeneration phase one May 22, 2019
@vitornesello vitornesello requested a review from guimarqu May 22, 2019 10:38
@@ -1,4 +1,4 @@
struct ColumnGeneration <: AbstractAlgorithm end
struct FullColumnGeneration <: AbstractAlgorithm end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why Full?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does phase one and phase two. You dont like the name?

@vitornesello vitornesello merged commit 29c7c5f into master May 22, 2019
@vitornesello vitornesello deleted the cg_pure_ph_one branch May 22, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants