Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isnothing(stage) on colgen stopping condition #859

Merged
merged 1 commit into from
May 3, 2023

Conversation

najaverzat
Copy link
Contributor

@najaverzat najaverzat commented May 3, 2023

close #856

@najaverzat najaverzat requested a review from guimarqu May 3, 2023 14:57
@najaverzat najaverzat linked an issue May 3, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1af6abb) 67.20% compared to head (4e458e9) 67.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #859   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files          77       77           
  Lines        5812     5812           
=======================================
  Hits         3906     3906           
  Misses       1906     1906           
Impacted Files Coverage Δ
src/ColGen/interface.jl 71.96% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@guimarqu guimarqu merged commit 405c12d into master May 3, 2023
@guimarqu guimarqu deleted the colgenstop-stages branch May 3, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent colgen from running when no more stage
2 participants