add tests stop_when_inf_db and infeasible_phase_output #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guimarqu
reviewed
May 3, 2023
guimarqu
reviewed
May 3, 2023
src/Algorithm/colgen.jl
Outdated
Comment on lines
162
to
164
| optstate = OptimizationState(master) | ||
|
|
||
| return _colgen_optstate_output(result, master, optstate) |
There was a problem hiding this comment.
You should create the OptimizationState inside _colgen_optstate_output.
Co-authored-by: Guillaume Marques <[email protected]>
Co-authored-by: Guillaume Marques <[email protected]>
Co-authored-by: Guillaume Marques <[email protected]>
|
Can you mark as broken all tests that do not pass, please? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
==========================================
+ Coverage 67.20% 67.23% +0.02%
==========================================
Files 77 77
Lines 5812 5814 +2
==========================================
+ Hits 3906 3909 +3
+ Misses 1906 1905 -1
☔ View full report in Codecov by Sentry. |
guimarqu
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.