Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status on node to handle formulation modifications/updates by the algorithms #84

Merged
merged 2 commits into from
May 22, 2019

Conversation

vitornesello
Copy link
Collaborator

First version status + automatic prepare! calling each algorithm

@vitornesello vitornesello requested a review from guimarqu May 21, 2019 14:41
@vitornesello
Copy link
Collaborator Author

Fix Issue #80

@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

Merging #84 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   91.41%   91.44%   +0.02%     
==========================================
  Files          33       33              
  Lines        1468     1473       +5     
==========================================
+ Hits         1342     1347       +5     
  Misses        126      126
Impacted Files Coverage Δ
src/algorithms/reformulationsolver.jl 93.33% <ø> (-0.06%) ⬇️
src/node.jl 93.2% <100%> (+0.34%) ⬆️
src/algorithms/algorithm.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f6021...b6343f7. Read the comment docs.

src/node.jl Outdated
@@ -43,13 +48,14 @@ mutable struct Node <: AbstractNode
branch::Union{Nothing, Branch} # branch::Id{Constraint}
algorithm_records::Dict{Type{<:AbstractAlgorithm},AbstractAlgorithmRecord}
record::NodeRecord
statuses::FormulationStatus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status

@vitornesello vitornesello merged commit 78fcc56 into master May 22, 2019
@vitornesello vitornesello deleted the node_statuses branch May 22, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants