Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move demos in ColunaDemos.jl #76

Merged
merged 11 commits into from
May 20, 2019
Merged

Move demos in ColunaDemos.jl #76

merged 11 commits into from
May 20, 2019

Conversation

guimarqu
Copy link
Contributor

@guimarqu guimarqu commented May 20, 2019

Fixes issue #73

@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files          33       33           
  Lines        1477     1477           
=======================================
  Hits         1236     1236           
  Misses        241      241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c1268...e84d062. Read the comment docs.

@guimarqu guimarqu requested a review from vitornesello May 20, 2019 09:50
Copy link
Collaborator

@vitornesello vitornesello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the directories test/models/ and examples/ from Coluna.
Also, add to ColunaDemos.jl the function to check the gap solutions. This function is written in examples/GeneralizedAssignment_SimpleColGen/run_sgap.jl

@guimarqu guimarqu merged commit dae140b into master May 20, 2019
@guimarqu guimarqu deleted the mvdemos branch August 5, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants