Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the double addition of deactivated columns #727

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

artalvpes
Copy link
Collaborator

Fixes a bug in the double addition (in the same iteration) of a column that was deactivated in the master. Still need a specific unit test for that.

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 80.03% // Head: 80.06% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (8715faf) compared to base (fa33acb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   80.03%   80.06%   +0.03%     
==========================================
  Files          59       59              
  Lines        5791     5795       +4     
==========================================
+ Hits         4635     4640       +5     
+ Misses       1156     1155       -1     
Impacted Files Coverage Δ
src/Algorithm/colgen.jl 82.26% <100.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@guimarqu guimarqu marked this pull request as ready for review September 27, 2022 19:24
@guimarqu guimarqu merged commit a11158d into master Sep 27, 2022
@guimarqu guimarqu deleted the fix_duplicate_deactivated_cols branch September 27, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants