Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify linear algebra operations syntax in colgen #712

Merged
merged 4 commits into from
Sep 8, 2022
Merged

Conversation

guimarqu
Copy link
Contributor

@guimarqu guimarqu commented Sep 6, 2022

  • data structure to store pre-computed information for the subgradient
  • replacing all custom code for linear algebra with a generic one
  • restructuring a little bit the MP/solutions.jl file (methods on abstract solution/primal solution/dual solution/linear algebra)

@guimarqu guimarqu changed the title Simplify linear algebra operations in colgen Simplify linear algebra operations syntax in colgen Sep 6, 2022
@guimarqu guimarqu requested a review from rrsadykov September 6, 2022 09:31
src/Algorithm/colgen.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #712 (661f9ad) into master (5f56232) will decrease coverage by 0.01%.
The diff coverage is 93.79%.

@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   86.27%   86.26%   -0.02%     
==========================================
  Files          58       58              
  Lines        5765     5724      -41     
==========================================
- Hits         4974     4938      -36     
+ Misses        791      786       -5     
Impacted Files Coverage Δ
src/Coluna.jl 100.00% <ø> (ø)
src/MathProg/vcids.jl 88.57% <0.00%> (-2.86%) ⬇️
src/Algorithm/colgenstabilization.jl 94.73% <83.33%> (-3.03%) ⬇️
src/MathProg/solutions.jl 87.03% <94.64%> (+5.30%) ⬆️
src/Algorithm/colgen.jl 80.72% <95.38%> (+0.98%) ⬆️
src/ColunaBase/solsandbounds.jl 89.82% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@guimarqu guimarqu merged commit 99ca1ca into master Sep 8, 2022
@guimarqu guimarqu deleted the spmv_io branch September 8, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant