Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add support for maximisation #71

Merged
merged 4 commits into from
May 17, 2019
Merged

WIP: Add support for maximisation #71

merged 4 commits into from
May 17, 2019

Conversation

vitornesello
Copy link
Collaborator

@vitornesello vitornesello commented May 14, 2019 •
edited
Loading

  • Add example of model with maximisation objective function
  • Fix bugs that WILL arrise

@vitornesello vitornesello added the enhancement New feature or request label May 14, 2019
@vitornesello vitornesello added this to the v0.2 milestone May 14, 2019
@vitornesello vitornesello mentioned this pull request May 14, 2019
Closed
4 tasks
@vitornesello
Maximization bug fixes (#72)
35e56ae 
* art_var cost and coeff depending on objective sense

* set correct objective sense in decomposition

* add function contrib_improves mlp to decide if a columns has an improving contribution on master depending on objective sense

* compute reduced cost depending on objective sense

* update to_be_pruned

* revert cost change
@codecov-io
Copy link

codecov-io commented May 15, 2019 •
edited
Loading

Codecov Report

Merging #71 into master will increase coverage by 0.93%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   81.93%   82.86%   +0.93%     
==========================================
  Files          33       33              
  Lines        1450     1459       +9     
==========================================
+ Hits         1188     1209      +21     
+ Misses        262      250      -12
Impacted Files Coverage Δ
src/solsandbounds.jl 81.33% <100%> (+8.36%) ⬆️
src/solvers/colgen.jl 91.89% <100%> (+0.14%) ⬆️
src/node.jl 92.85% <100%> (+0.07%) ⬆️
src/decomposition.jl 98.95% <100%> (+0.03%) ⬆️
src/formulation.jl 69.04% <100%> (+0.64%) ⬆️
src/MOIinterface.jl 59.75% <0%> (+1.21%) ⬆️
src/bbtree.jl 92.37% <0%> (+2.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef0e09c...4f329aa. Read the comment docs.

@vitornesello
Copy link
Collaborator Author

Merging because guillaume has accepted the merge of the bug fixes branch

@vitornesello vitornesello merged commit 40cebf1 into master May 17, 2019
@vitornesello vitornesello deleted the feature-maximization branch May 20, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@vitornesello @codecov-io