Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning: Problem setters + style #70

Merged
merged 3 commits into from
May 15, 2019
Merged

Cleaning: Problem setters + style #70

merged 3 commits into from
May 15, 2019

Conversation

vitornesello
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented May 14, 2019

Codecov Report

Merging #70 into master will increase coverage by 0.15%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   81.98%   82.14%   +0.15%     
==========================================
  Files          32       32              
  Lines        1460     1467       +7     
==========================================
+ Hits         1197     1205       +8     
+ Misses        263      262       -1
Impacted Files Coverage Δ
src/solvers/colgen.jl 91.81% <ø> (ø) ⬆️
src/problem.jl 95.65% <100%> (+7.65%) ⬆️
src/formulation.jl 72.12% <100%> (+0.39%) ⬆️
src/bbtree.jl 89.83% <75%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a2c291...e2875e4. Read the comment docs.

@vitornesello vitornesello changed the title Problem setters Problem setters + style May 15, 2019
@guimarqu guimarqu changed the title Problem setters + style Cleaning: Problem setters + style May 15, 2019
@logmsg LogLevel(-3) "MOI formulation before sync: "
# _show_optimizer(form.moi_optimizer)
sync_solver(form)
@logmsg LogLevel(-2) "Coluna formulation after sync: "
@logmsg LogLevel(-2) form
@logmsg LogLevel(-2) "MOI formulation after sync: "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something missing after this output

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the line is commented because i cannot embed in the log_msg. we have to find a way to fix this

@vitornesello vitornesello merged commit 7e02905 into master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants