Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract branching rule selection / Start isolating interface from implementation in branching #678

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

guimarqu
Copy link
Contributor

@guimarqu guimarqu commented Aug 8, 2022

  • I extracted branching rule selection from the run! method.
  • I started to isolate the interface of branching algorithms from the implementation (I grouped elements of the interface in a new file branching/interface)

In next PR, I'll try to remove the BranchingGroup data structure because I feel like it is used to standardize communication between elements of the branching algorithm. I think this standardization should be done with an interface implemented by concrete branching candidates. Moreover, the current implementation of BranchingGroup contains an abstract candidate. I'll try to get rid of this abstract type.

@guimarqu guimarqu merged commit 563df14 into tree_search Aug 8, 2022
@guimarqu guimarqu deleted the select_br_candidates branch August 11, 2022 05:54
guimarqu added a commit that referenced this pull request Aug 17, 2022
…lementation in branching (#678)

* isolate branching rule selection + group branching interface

* wip

* ok
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant