Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dual bound of tree search is dual bound of open nodes #598

Merged
merged 3 commits into from
Sep 8, 2021
Merged

dual bound of tree search is dual bound of open nodes #598

merged 3 commits into from
Sep 8, 2021

Conversation

guimarqu
Copy link
Contributor

@guimarqu guimarqu commented Sep 8, 2021

fix #597

@guimarqu guimarqu requested a review from rrsadykov September 8, 2021 08:50
@codecov
Copy link

codecov bot commented Sep 8, 2021 •
edited
Loading

Codecov Report

Merging #598 (b1a7db9) into master (d79d546) will decrease coverage by 0.73%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
- Coverage   86.67%   85.94%   -0.74%     
==========================================
  Files          47       47              
  Lines        4809     4801       -8     
==========================================
- Hits         4168     4126      -42     
- Misses        641      675      +34
Impacted Files Coverage Δ
src/Algorithm/treesearch.jl 92.85% <100.00%> (-1.43%) ⬇️
src/Algorithm/colgen.jl 90.52% <0.00%> (-4.99%) ⬇️
src/MathProg/optimizerwrappers.jl 86.25% <0.00%> (-2.50%) ⬇️
src/Algorithm/branching/branchingalgo.jl 88.70% <0.00%> (-2.42%) ⬇️
src/Algorithm/basic/solveipform.jl 87.36% <0.00%> (-2.11%) ⬇️
src/MOIcallbacks.jl 94.82% <0.00%> (-1.79%) ⬇️
src/Algorithm/branching/branchinggroup.jl 86.81% <0.00%> (-1.10%) ⬇️
src/ColunaBase/storage.jl 87.03% <0.00%> (-0.93%) ⬇️
src/Algorithm/conquer.jl 80.99% <0.00%> (-0.83%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d79d546...b1a7db9. Read the comment docs.

@guimarqu guimarqu mentioned this pull request Sep 8, 2021
Merged
rrsadykov
rrsadykov reviewed Sep 8, 2021
View reviewed changes
test/full_instances_tests.jl

JuMP.optimize!(model)

@test JuMP.objective_bound(model) ≈ 1547.3889
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that this test is reproducible? Branching decisions may be different depending on the fractional solution (which depends on the LP solver).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm not satisfied with this test, I'm leaving it until we think about better tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it fails for some reason, we can replace @test by @test_broken

@guimarqu guimarqu enabled auto-merge (squash) September 8, 2021 14:00
@guimarqu guimarqu merged commit 808b47d into master Sep 8, 2021
@guimarqu guimarqu deleted the fix_db_of_treesearch branch September 17, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrsadykov rrsadykov rrsadykov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dual bound of tree search should be equal to the worst dual bound of open nodes
2 participants
@guimarqu @rrsadykov