Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci #59

Merged
merged 11 commits into from
May 8, 2019
Merged

Update ci #59

merged 11 commits into from
May 8, 2019

Conversation

guimarqu
Copy link
Contributor

@guimarqu guimarqu commented May 7, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented May 7, 2019

Codecov Report

Merging #59 into master will increase coverage by 15.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #59       +/-   ##
===========================================
+ Coverage    66.5%   81.54%   +15.04%     
===========================================
  Files          30       31        +1     
  Lines        1224     1463      +239     
===========================================
+ Hits          814     1193      +379     
+ Misses        410      270      -140
Impacted Files Coverage Δ
src/solvers/generatechildrennodes.jl 88.57% <0%> (-4.29%) ⬇️
src/globals.jl 100% <0%> (ø) ⬆️
src/projection.jl 100% <0%> (ø) ⬆️
src/strategies/simplebnp.jl 100% <0%> (ø) ⬆️
src/solvers/masteripheur.jl 100% <0%> (ø) ⬆️
src/Coluna.jl 100% <0%> (ø)
src/clone.jl 96.55% <0%> (+0.55%) ⬆️
src/decomposition.jl 97.84% <0%> (+0.7%) ⬆️
src/solvers/colgen.jl 91.89% <0%> (+0.98%) ⬆️
src/MOIwrapper.jl 90.58% <0%> (+4.65%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afaa3f9...570f797. Read the comment docs.

@guimarqu
Copy link
Contributor Author

guimarqu commented May 8, 2019

Since BlockDecomposition is not a registered package, Pkgcannot resolve dependencies of Coluna. So we have to clone BlockDecomposition and then resolve.

https://discourse.julialang.org/t/package-manager-resolve-complaining-of-unsatisfiable-requirements-due-to-no-known-versions/23778

@guimarqu guimarqu merged commit cc3b908 into master May 8, 2019
@guimarqu guimarqu deleted the fix-cov branch May 8, 2019 16:10
@guimarqu guimarqu mentioned this pull request May 8, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants