Add MOI methods: delete and modify #584
Conversation
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
==========================================
- Coverage 86.82% 86.65% -0.18%
==========================================
Files 47 47
Lines 4752 4796 +44
==========================================
+ Hits 4126 4156 +30
- Misses 626 640 +14
Continue to review full report at Codecov.
|
| push!(varids, varid) | ||
| end | ||
| for varid in varids | ||
| coefmatrix[constrid, varid] = 0.0 |
There was a problem hiding this comment.
What happens if you do :
for (varid, _) in @view coefmatrix[constrid, :]
coefmatrix[constrid, varid] = 0.0
endThere was a problem hiding this comment.
I think it enters in an undefined behavior because the size of the array that stores the coefficient matrix may change.
There was a problem hiding this comment.
Exactly, I got an error for accessing an invalid index.
|
|
||
| function Base.delete!(form::Formulation, constrid::ConstrId) | ||
| delete!(form.buffer.constr_buffer.added, constrid) | ||
| delete!(form.manager.constrs, constrid) |
There was a problem hiding this comment.
| delete!(form.manager.constrs, constrid) | |
| delete!(form.manager.constrs, constrid) | |
| return |
| for (varid, _) in @view coefmatrix[constrid, :] | ||
| push!(varids, varid) | ||
| end |
There was a problem hiding this comment.
I think you should change the coefficients in MathProg.delete!.
|
I need these changes to fix #583 so I merge into master. |
* add delete and modify methods for constraints * add delete and modify methods for variables * fix merge commit * add delete! and use proper get and set methods * apply suggestions from PR #584 Co-authored-by: Guillaume Marques <[email protected]>
No description provided.