Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Node Finalizer #568

Merged
merged 16 commits into from
Oct 2, 2021
Merged

Adding Node Finalizer #568

merged 16 commits into from
Oct 2, 2021

Conversation

artalvpes
Copy link
Collaborator

@artalvpes artalvpes commented Jul 26, 2021

Include a new custom algorithm, called node finalizer, that may conquer the node and/or find new feasible solutions. Some code let in the test function should still be encapsulated into additional API functions for a more user-friendly interface.

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #568 (d1e1bb1) into master (6edb71d) will decrease coverage by 0.00%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
- Coverage   85.58%   85.58%   -0.01%     
==========================================
  Files          47       47              
  Lines        4801     4834      +33     
==========================================
+ Hits         4109     4137      +28     
- Misses        692      697       +5     
Impacted Files Coverage Δ
src/Algorithm/conquer.jl 84.10% <93.75%> (+2.28%) ⬆️
src/Algorithm/branching/branchingalgo.jl 88.88% <100.00%> (-0.63%) ⬇️
src/Algorithm/colgen.jl 85.78% <100.00%> (ø)
src/Algorithm/branching/branchinggroup.jl 87.91% <0.00%> (-1.10%) ⬇️
src/ColunaBase/storage.jl 87.03% <0.00%> (-0.93%) ⬇️
src/MathProg/optimizerwrappers.jl 86.41% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6edb71d...d1e1bb1. Read the comment docs.

@artalvpes artalvpes changed the title Extending heuristic functionality Adding Node Finalizer Sep 8, 2021
@artalvpes artalvpes marked this pull request as ready for review September 17, 2021 20:47
src/Algorithm/branching/branchingalgo.jl Show resolved Hide resolved
# ParameterisedNodeFinalizer
####################################################################

struct ParameterisedNodeFinalizer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call it NodeFinalizer or ConquerPostProcessor ?

src/Algorithm/conquer.jl Outdated Show resolved Hide resolved
src/Algorithm/conquer.jl Outdated Show resolved Hide resolved
src/Algorithm/conquer.jl Outdated Show resolved Hide resolved
src/Algorithm/conquer.jl Outdated Show resolved Hide resolved
src/Algorithm/conquer.jl Show resolved Hide resolved
test/node_finalizer_tests.jl Show resolved Hide resolved
@guimarqu guimarqu enabled auto-merge (squash) October 2, 2021 12:20
@guimarqu guimarqu merged commit 5870353 into master Oct 2, 2021
@guimarqu guimarqu deleted the extending_heuristic_functionality branch October 10, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants