rm support of anonymous variables & constraints #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 86.15% 86.22% +0.07%
==========================================
Files 47 47
Lines 4687 4698 +11
==========================================
+ Hits 4038 4051 +13
+ Misses 649 647 -2
Continue to review full report at Codecov.
|
laradicp
reviewed
Jul 20, 2021
|
|
||
| m = BlockModel(coluna) | ||
| anonymous_var_model!(m) | ||
| # The variable is annotated in the master. |
There was a problem hiding this comment.
I didn't understand why this happens.
There was a problem hiding this comment.
Haha ok. I tried to find a reason but couldn't yet, I can keep searching if it's relevant.
laradicp
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #553
At the moment, Coluna does not detect anonymous variables when
direct_mode = falsebut the annotation of an anony var is nothing (cf atoptima/BlockDecomposition.jl@d86fa7e)