Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve disaggregated solution #547

Merged
merged 8 commits into from
Jul 1, 2021
Merged

Retrieve disaggregated solution #547

merged 8 commits into from
Jul 1, 2021

Conversation

laradicp
Copy link
Contributor

@laradicp laradicp commented Jun 18, 2021

fix #540

  • getsolutions retrieves the disaggregated solution from disagg_result in Optimizer

@guimarqu
Copy link
Contributor

It's a good start.

The disaggregated solution may have columns with fractional values if we proved that there exists a combination that leads to feasible columns with integer values. Since we don't have such a mechanism, this solution may be infeasible.

In the meantime, we can check the integrality of columns from sps with upper multiplicity greater than 1 in the feasibility checker.

Let's keep this issue for later.

@guimarqu
Copy link
Contributor

By the way, I wouldn't store the OptimizationStates in a vector because it creates an implicit convention that we'll forget (1st entry for the aggregated solution, 2nd for the disaggregated one).

@@ -0,0 +1,52 @@
function sol_disaggregation_tests()
I = 1:20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you should test the feature by creating a new algorithm that returns a pre-defined solution. Then, you test if you can retrieve the same solution with the new interface.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I misclicked)

@guimarqu guimarqu self-requested a review June 24, 2021 20:34
@laradicp laradicp marked this pull request as ready for review June 30, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve disagreggated solution
2 participants