Fix conditions to restart colgen when using lazy cut gen #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
- Coverage 83.84% 83.76% -0.08%
==========================================
Files 47 47
Lines 4674 4676 +2
==========================================
- Hits 3919 3917 -2
- Misses 755 759 +4
Continue to review full report at Codecov.
|
guimarqu
commented
Apr 15, 2021
rrsadykov
requested changes
Apr 15, 2021
| deactivate_artificial_vars = false, | ||
| enforce_integrality = false, | ||
| log_level = 2 | ||
| deactivate_artificial_vars=false, |
There was a problem hiding this comment.
why did you remove spaces around =? This is a new convention? I think with spaces it looks better
There was a problem hiding this comment.
It's the formatter and it looks like to be the convention : https://github.com/invenia/BlueStyle#keyword-arguments
rrsadykov
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Colgen cannot declare the convergence just after an essential cut has been added to the master.
Now, colgen will restart only if we add an essential cut in phase 2.
We still perform essential cut generation as I said in #452 .