Update setvar! and setconstr! docstrings
#497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
=======================================
Coverage 83.83% 83.83%
=======================================
Files 47 47
Lines 4696 4696
=======================================
Hits 3937 3937
Misses 759 759
Continue to review full report at Codecov.
|
guimarqu
reviewed
Apr 5, 2021
src/MathProg/formulation.jl
Outdated
| @@ -128,7 +128,7 @@ set_matrix_coeff!( | |||
| is_active::Bool = true, | |||
| is_explicit::Bool = true, | |||
| moi_index::MoiVarIndex = MoiVarIndex(), | |||
| members = nothing, | |||
| members::Union{ConstrMembership, Nothing} = nothing, | |||
There was a problem hiding this comment.
I think it's misleading because ConstrMembership is an alias for Dict{Constrid, Float64}. I think it's better to remove all the types and describe each argument in a list.
There was a problem hiding this comment.
True. Same for setconstr!?
laradicp
changed the title
setvar! docstringsetvar! and setconstr! docstrings
guimarqu
reviewed
Apr 6, 2021
Co-authored-by: Guillaume Marques <[email protected]>
guimarqu
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.