-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Storage -> (Storage) Unit #471
Conversation
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
=======================================
Coverage 82.28% 82.28%
=======================================
Files 51 51
Lines 4702 4702
=======================================
Hits 3869 3869
Misses 833 833
Continue to review full report at Codecov.
|
@rrsadykov ready for review. |
@@ -174,23 +175,23 @@ decreaseparticipation!(essc::EmptyRecordStateContainer) = nothing | |||
""" | |||
StorageContainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StorageUnitContainer or UnitContainer
(model of a problem). A problem may have different formulations. | ||
We may rename "formulation" to "model" after. | ||
Different algorithms may be applied to a formulation. | ||
A formulation should contain a dictionary of storage units |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, any model should contain a storage (a dictionary of storage units).
Is there an advantage of having AbstractFormulation, could we derive Formulation and Reformulation directly from AbstractModel? I have an impression that everything defined for AbstractFormulation should be defined for AbstractModel and moved to ColunaBase
I changed comments related to the title of the PR only. I do each task of #330 in a separate PR because otherwise I'll get lost in my changes haha |
task for #330