Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Storage -> (Storage) Unit #471

Merged
merged 12 commits into from
Mar 19, 2021
Merged

Rename Storage -> (Storage) Unit #471

merged 12 commits into from
Mar 19, 2021

Conversation

guimarqu
Copy link
Contributor

@guimarqu guimarqu commented Mar 18, 2021

task for #330

@guimarqu guimarqu requested a review from rrsadykov March 18, 2021 16:13
@guimarqu guimarqu marked this pull request as ready for review March 18, 2021 16:13
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #471 (f154343) into master (f1941be) will not change coverage.
The diff coverage is 82.39%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #471   +/-   ##
=======================================
  Coverage   82.28%   82.28%           
=======================================
  Files          51       51           
  Lines        4702     4702           
=======================================
  Hits         3869     3869           
  Misses        833      833           
Impacted Files Coverage Δ
src/Algorithm/Algorithm.jl 100.00% <ø> (ø)
src/Algorithm/branching/branchingrule.jl 20.00% <ø> (ø)
src/Algorithm/divide.jl 54.54% <ø> (ø)
src/Algorithm/node.jl 77.77% <ø> (ø)
src/MathProg/types.jl 79.16% <ø> (ø)
src/Algorithm/storage.jl 76.86% <42.85%> (ø)
src/Algorithm/preprocessing.jl 76.75% <72.58%> (ø)
src/Algorithm/data.jl 75.00% <72.72%> (ø)
src/Algorithm/formstorages.jl 52.60% <75.00%> (ø)
src/Algorithm/colgenstabilization.jl 99.22% <97.61%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1941be...f154343. Read the comment docs.

@guimarqu guimarqu marked this pull request as draft March 18, 2021 18:02
@guimarqu guimarqu changed the title Rename Storage -> Record Rename Storage -> (Storage) Unit Mar 18, 2021
@guimarqu guimarqu marked this pull request as ready for review March 18, 2021 21:38
@guimarqu
Copy link
Contributor Author

@rrsadykov ready for review.

src/Algorithm/basic/solveipform.jl Outdated Show resolved Hide resolved
src/Algorithm/branching/branchingalgo.jl Outdated Show resolved Hide resolved
src/Algorithm/branching/branchingalgo.jl Show resolved Hide resolved
src/Algorithm/branching/branchingrule.jl Outdated Show resolved Hide resolved
src/Algorithm/branching/branchingrule.jl Show resolved Hide resolved
src/Algorithm/storage.jl Outdated Show resolved Hide resolved
@@ -174,23 +175,23 @@ decreaseparticipation!(essc::EmptyRecordStateContainer) = nothing
"""
StorageContainer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StorageUnitContainer or UnitContainer

src/Algorithm/storage.jl Show resolved Hide resolved
src/Algorithm/treesearch.jl Outdated Show resolved Hide resolved
(model of a problem). A problem may have different formulations.
We may rename "formulation" to "model" after.
Different algorithms may be applied to a formulation.
A formulation should contain a dictionary of storage units
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, any model should contain a storage (a dictionary of storage units).

Is there an advantage of having AbstractFormulation, could we derive Formulation and Reformulation directly from AbstractModel? I have an impression that everything defined for AbstractFormulation should be defined for AbstractModel and moved to ColunaBase

@guimarqu guimarqu requested a review from rrsadykov March 19, 2021 09:48
@guimarqu
Copy link
Contributor Author

I changed comments related to the title of the PR only. I do each task of #330 in a separate PR because otherwise I'll get lost in my changes haha

@guimarqu guimarqu merged commit e83aac5 into master Mar 19, 2021
@guimarqu guimarqu deleted the rename_storage2 branch March 19, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants