test empty model solution and improve error msg #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
==========================================
+ Coverage 80.55% 80.59% +0.04%
==========================================
Files 50 50
Lines 4305 4304 -1
==========================================
+ Hits 3468 3469 +1
+ Misses 837 835 -2
Continue to review full report at Codecov.
|
guimarqu
reviewed
Feb 22, 2021
test/issues_tests.jl
Outdated
| ) | ||
| model = BlockModel(coluna, direct_model = true) | ||
| optimize!(model) | ||
| @test JuMP.objective_value(model) == Inf |
There was a problem hiding this comment.
The objective value must be 0.
test/issues_tests.jl
Outdated
| optimize!(model) | ||
| catch e | ||
| @test repr(e) == "ErrorException(\"Cannot apply run! for arguments Coluna.Algorithm.TreeSearchAlgorithm, Coluna.Algorithm.ModelData, Coluna.Algorithm.OptimizationInput{Coluna.MathProg.Formulation{Coluna.MathProg.Original},Coluna.MathProg.MinSense}.\")" | ||
| end |
There was a problem hiding this comment.
You can replace this block by @test_throws ExceptionError optimize!(model).
guimarqu
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.