Fixed a bug when restoring master cuts in strong branching

src/Algorithm/basic/cutcallback.jl

@@ -27,7 +27,8 @@ end
 
 # CutCallbacks does not have child algorithms, therefore get_child_algorithms() is not defined
 
-function get_storages_usage(algo::CutCallbacks, form::Formulation{MathProg.AbstractMasterDuty}) 
+function get_storages_usage(algo::CutCallbacks, form::Formulation{Duty}
+    ) where {Duty<:MathProg.AbstractFormDuty} 
     return [(form, MasterCutsStoragePair, READ_AND_WRITE)]
 end
 

src/Algorithm/basic/solvelpform.jl

@@ -47,7 +47,12 @@ function optimize_lp_form!(
     algo::SolveLpForm, optimizer::MoiOptimizer, form::Formulation, result::OptimizationState
 )
     MOI.set(form.optimizer.inner, MOI.Silent(), algo.silent)
+    # MOI.set(form.optimizer.inner, MOI.RawParameter("Method"), 2)
     optimize_with_moi!(optimizer, form, result)
+    #Coluna.inc_lp_file_count()
+    #lpfile = "coluna_master$(Coluna.lp_file_count).lp"
+    #println("Writing LP file $lpfile")
+    #Gurobi.GRBwrite(form.optimizer.inner, lpfile)
     return
 end
 

src/Algorithm/branching/branchingalgo.jl

@@ -178,10 +178,6 @@ function perform_strong_branching_with_phases!(
 
         sort!(groups, rev = true, by = x -> (x.isconquered, x.score))
 
-        if groups[1].isconquered
-            nb_candidates_for_next_phase == 1 
-        end
-
         # before deleting branching groups which are not kept for the next phase
         # we need to remove storage states kept in these nodes
         for group_index = nb_candidates_for_next_phase + 1 : length(groups) 

src/Algorithm/storage.jl

@@ -90,6 +90,13 @@ const StorageTypePair = Pair{DataType, DataType}
 #         be restored for writing (all other storages are restored anyway but just for reading)
 const StoragesUsageDict = Dict{Tuple{AbstractModel, StorageTypePair}, StorageAccessMode}
 
+function Base.show(io::IO, stoUsaDict::StoragesUsageDict)
+    print(io, "storage usage dict [")
+    for usage in stoUsaDict
+        print(io, " (", typeof(usage[1][1]), ", ", usage[1][2], ") => ", usage[2])
+    end
+    print(io, " ]")
+end
 
 """
     function add_storage_pair_usage!(::StoragesUsageDict, ::AbstractModel, ::StorageTypePair, ::StorageAccessMode)

src/Algorithm/treesearch.jl

@@ -218,7 +218,7 @@ function print_node_in_branching_tree_file(
             ncur = get_tree_order(node)
             time = elapsed_optim_time(env)
             if ip_gap_closed(getoptstate(node))
-                @printf file "\n\tn%i [label= \"N_%i (%.0f s) \\nPRUNED\"];" ncur ncur time
+                @printf file "\n\tn%i [label= \"N_%i (%.0f s) \\n[PRUNED , %.4f]\"];" ncur ncur time pb
             else
                 @printf file "\n\tn%i [label= \"N_%i (%.0f s) \\n[%.4f , %.4f]\"];" ncur ncur time db pb
             end

src/Coluna.jl

@@ -21,6 +21,40 @@ const TOL = 1e-8 # if - ϵ_tol < val < ϵ_tol, we consider val = 0
 const TOL_DIGITS = 8 # because round(val, digits = n) where n is from 1e-n
 ###
 
+### Debugging tools
+global debug_count = 0
+function inc_debug_count()
+    global debug_count += 1
+    return
+end
+function debug_stack()
+    for l in stacktrace()
+        println(l)
+    end
+end
+macro debug()
+    return esc(:(
+        cont = false;
+        while !cont
+            print("\njulia> ");
+            cmd = readline();
+            if cmd == ""
+                cont = true;
+            else
+                try
+                    eval(Meta.parse(cmd));
+                catch err
+                    println(err);
+                end
+            end
+        end
+    ))
+end
+###
+
+# submodules
+export ColunaBase, MathProg, Algorithm
+
 const _to = TO.TimerOutput()
 
 export Algorithm, ColunaBase, MathProg, Env, DefaultOptimizer, Parameters,

src/MOIcallbacks.jl

@@ -100,7 +100,7 @@ function MOI.submit(
     end
 
     constr = setconstr!(
-        form, "", MasterMixedConstr;
+        form, "", MasterBendCutConstr; #TODO: Create a specific type for user cuts
         rhs = rhs,
         kind = Essential,
         sense = sense,