Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matrix fill mode when filling the formulations #427

Merged
merged 14 commits into from
Dec 29, 2020
Merged

Conversation

guimarqu
Copy link
Contributor

@guimarqu guimarqu commented Dec 28, 2020

fix #406

Tests should pass when DynamicSparseArrays v0.3.0 released

@guimarqu guimarqu marked this pull request as ready for review December 28, 2020 21:48
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #427 (331dd9c) into master (d894701) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   80.11%   80.12%           
=======================================
  Files          52       52           
  Lines        4204     4206    +2     
=======================================
+ Hits         3368     3370    +2     
  Misses        836      836           
Impacted Files Coverage Δ
src/Algorithm/colgen.jl 95.88% <ø> (ø)
src/Coluna.jl 100.00% <ø> (ø)
src/MathProg/manager.jl 50.00% <ø> (ø)
src/optimize.jl 96.22% <ø> (ø)
src/MathProg/clone.jl 100.00% <100.00%> (ø)
src/decomposition.jl 97.97% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d894701...331dd9c. Read the comment docs.

@guimarqu guimarqu merged commit 840e111 into master Dec 29, 2020
@guimarqu guimarqu deleted the reformulation_perf branch December 29, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reformulation is very time consuming for medium/large model
2 participants