Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views for columns and constraints & rm MembersMatrix #371

Merged
merged 4 commits into from
Jun 13, 2020
Merged

Conversation

guimarqu
Copy link
Contributor

@guimarqu guimarqu commented Jun 13, 2020

  • view for matrix slices
  • move matrix in DynamicSparseArrays
  • update dependencies

I'm using Juno now and it removes blank spaces at ends of line, so there are lot of changes...

@guimarqu guimarqu changed the title Views for columns and constraints Views for columns and constraints & rm MembersMatrix Jun 13, 2020
@guimarqu guimarqu requested a review from rrsadykov June 13, 2020 16:42
@guimarqu guimarqu marked this pull request as ready for review June 13, 2020 16:42
@guimarqu
Copy link
Contributor Author

Tests will pass after tag of v0.2.4 in DynamicSparseArrays.

@rrsadykov @vitornesello @FD-V I think we are ready to release v0.3.

@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #371 into master will decrease coverage by 0.01%.
The diff coverage is 95.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   77.34%   77.33%   -0.02%     
==========================================
  Files          52       51       -1     
  Lines        3969     3962       -7     
==========================================
- Hits         3070     3064       -6     
+ Misses        899      898       -1     
Impacted Files Coverage Δ
src/ColunaBase/ColunaBase.jl 100.00% <ø> (ø)
src/MathProg/formulation.jl 72.14% <88.88%> (ø)
src/MathProg/decomposition.jl 94.35% <90.00%> (ø)
src/Algorithm/colgen.jl 90.64% <100.00%> (ø)
src/MathProg/manager.jl 68.75% <100.00%> (ø)
src/MathProg/optimizerwrappers.jl 70.44% <100.00%> (ø)
src/MathProg/projection.jl 89.47% <100.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e21eda...e853f94. Read the comment docs.

@rrsadykov
Copy link
Collaborator

ok for me to release 0.3. In the features, we need to pass stabilization, cut generation, strong branching and clean up to beta list.

@guimarqu guimarqu merged commit d292b48 into master Jun 13, 2020
@guimarqu guimarqu deleted the views branch June 13, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants