-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-threading on solving subproblems #345
Conversation
@guimarqu @cristianabentes , I also didn't add Gurobi packages since a license is needed to run it, but it's important to note that this parallelization will only work with Gurobi. Should we keep it like this to merge with master? |
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 75.49% 75.29% -0.20%
==========================================
Files 50 50
Lines 3664 3672 +8
==========================================
- Hits 2766 2765 -1
- Misses 898 907 +9
Continue to review full report at Codecov.
|
If I have my own thread-safe algorithm to solve the subproblem, it should work, isn't it ? |
Yes
Ok, but meanwhile we need Gurobi. We will leave the execution with Gurobi only in our branch. On the master branch the parallelization will be turned off until the home-made solution is ready. |
src/Algorithm/colgen.jl
Outdated
dual_sol::DualSolution, sp_lbs::Dict{FormId, Float64}, sp_ubs::Dict{FormId, Float64} | ||
) | ||
threadstasks = Task[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, we don't need it anymore. I removed it.
This implementation needs Gurobi to work.