Dynamic sparse vector for solutions #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 83.48% 83.51% +0.02%
==========================================
Files 49 49
Lines 2918 2923 +5
==========================================
+ Hits 2436 2441 +5
Misses 482 482
Continue to review full report at Codecov.
|
src/parameters.jl
Outdated
| @@ -4,6 +4,8 @@ Base.@kwdef mutable struct Params | |||
| integrality_tolerance::Float64 = 1e-5 | |||
| absolute_optimality_tolerance::Float64 = 1e-5 | |||
| relative_optimality_tolerance::Float64 = 1e-5 | |||
| ϵ_tol::Float64 = 1e-6 # if - ϵ_tol < val < ϵ_tol, we consider val = 0 | |||
There was a problem hiding this comment.
Maybe remove all other tolerances and leave this one as tolerance?
src/parameters.jl
Outdated
| @@ -4,6 +4,8 @@ Base.@kwdef mutable struct Params | |||
| integrality_tolerance::Float64 = 1e-5 | |||
| absolute_optimality_tolerance::Float64 = 1e-5 | |||
| relative_optimality_tolerance::Float64 = 1e-5 | |||
| ϵ_tol::Float64 = 1e-6 # if - ϵ_tol < val < ϵ_tol, we consider val = 0 | |||
| integrality_tol_digits::Int = 6 # because round(val, digits = 6) | |||
There was a problem hiding this comment.
maybe tolerance_digits?
vitornesello
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fill_primal_solution.