Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix primal solution check #148

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Fix primal solution check #148

merged 1 commit into from
Jun 28, 2019

Conversation

guimarqu
Copy link
Contributor

Fix #146
Make some methods of AbstractSolution more generic

@guimarqu guimarqu requested a review from vitornesello June 27, 2019 14:47
@codecov-io
Copy link

codecov-io commented Jun 27, 2019

Codecov Report

Merging #148 into master will decrease coverage by 0.05%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   76.32%   76.26%   -0.06%     
==========================================
  Files          37       37              
  Lines        1812     1816       +4     
==========================================
+ Hits         1383     1385       +2     
- Misses        429      431       +2
Impacted Files Coverage Δ
src/incumbents.jl 80% <ø> (ø) ⬆️
src/algorithms/colgen.jl 94.77% <100%> (ø) ⬆️
src/solsandbounds.jl 83.52% <50%> (-1.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd50cb4...a1bbbba. Read the comment docs.

@guimarqu guimarqu merged commit a2fea84 into master Jun 28, 2019
@guimarqu guimarqu deleted the fix-PB branch June 28, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong bounds in small gap instance
3 participants