Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of formulation storages #1103

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

rrsadykov
Copy link
Collaborator

No description provided.

…ages_update

# Conflicts:
#	src/Algorithm/presolve/interface.jl
@rrsadykov rrsadykov requested a review from guimarqu October 25, 2023 12:23
Copy link
Contributor

@guimarqu guimarqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good after the removal of f = true.

register!(unit_tests, "storage_record", unit_static_var_constr_record, f = true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
register!(unit_tests, "storage_record", unit_static_var_constr_record, f = true)
register!(unit_tests, "storage_record", unit_static_var_constr_record)

@test ClMP.get_value_in_partial_sol(form, vars["v2"]) == -1.0
@test ClMP.get_value_in_partial_sol(form, vars["v3"]) == -2.0
end
register!(unit_tests, "storage_record", unit_partial_solution_record, f = true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
register!(unit_tests, "storage_record", unit_partial_solution_record, f = true)
register!(unit_tests, "storage_record", unit_partial_solution_record)

register!(unit_tests, "storage_record", unit_master_columns_record, f = true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
register!(unit_tests, "storage_record", unit_master_columns_record, f = true)
register!(unit_tests, "storage_record", unit_master_columns_record)

@guimarqu
Copy link
Contributor

Let's clean the tests before 0.8 release

@guimarqu guimarqu merged commit 9c44c75 into presolve_final_v1 Oct 25, 2023
3 checks passed
@guimarqu guimarqu deleted the formstorages_update branch October 25, 2023 12:30
guimarqu added a commit that referenced this pull request Oct 25, 2023
* partial sol propagation refactoring

* making progress in refactoring

* wip

* do not deactivate column of partial sol

* unprint form

* - Updated MasterColumnsUnit, StaticVarConstrUnit. (#1103)

- Added PartialSolutionUnit

* clean tests

---------

Co-authored-by: Ruslan Sadykov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants