Run conquer algorithm in TreeSearch only if conquer_output of the node is empty
#1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, we run conquer only if conquer_output is empty
|
Now, |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1076 +/- ##
==========================================
- Coverage 82.91% 82.88% -0.04%
==========================================
Files 89 89
Lines 7151 7150 -1
==========================================
- Hits 5929 5926 -3
- Misses 1222 1224 +2
☔ View full report in Codecov by Sentry. |
guimarqu
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a way to ensure that the conquer is not run again needlessly 1) after strong branching 2) at the root of the diving. After running the conquer algorithm, its output (
OptimizationState) is put to the node so that the divide algorithm can use it even if it is not run immediately after.In the future, we would need to define two conquer algorithms for the branch-and-bound (one for the root and one for other nodes), as for the moment we always rely on strong branching to do complete evaluation of the candidate branches. Sometimes, we may want to do a "partial" evaluation in the strong branching. Then, we would need to define an empty conquer algorithm which does nothing and returns nothing. In the when it is used, we would rely on the node to already possess a conquer output, which we then pass to the divide algorithm.