Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove children nodes from branching candidates #1072

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

rrsadykov
Copy link
Collaborator

Generating child nodes from branching candidates is moved from select!() to advanced_select!(). This allows us to simplify the interface of branching candidates (we remove nodes from them). This simplification also serves to prepare the diving implementation.

@rrsadykov rrsadykov requested a review from guimarqu September 21, 2023 15:55
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 93.10% and project coverage change: +0.03% 🎉

Comparison is base (afb1964) 82.56% compared to head (4c5580d) 82.60%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
+ Coverage   82.56%   82.60%   +0.03%     
==========================================
  Files          89       89              
  Lines        7148     7138      -10     
==========================================
- Hits         5902     5896       -6     
+ Misses       1246     1242       -4     
Files Changed Coverage Δ
src/Branching/candidate.jl 0.00% <ø> (ø)
src/TreeSearch/TreeSearch.jl 8.33% <ø> (+0.64%) ⬆️
src/Branching/Branching.jl 70.87% <90.47%> (-0.83%) ⬇️
src/Algorithm/branching/printer.jl 96.87% <100.00%> (ø)
src/Algorithm/branching/scores.jl 90.47% <100.00%> (-0.12%) ⬇️
src/Algorithm/branching/single_var_branching.jl 87.50% <100.00%> (-0.50%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guimarqu guimarqu merged commit bad4a12 into master Sep 22, 2023
5 checks passed
@rrsadykov rrsadykov deleted the branch_cand_simpl branch November 28, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants