Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for Methods related to Solutions #479

Closed
ItamarRocha opened this issue Mar 25, 2021 · 0 comments · Fixed by #485
Closed

Unit tests for Methods related to Solutions #479

ItamarRocha opened this issue Mar 25, 2021 · 0 comments · Fixed by #485
Assignees
Labels

Comments

@ItamarRocha
Copy link
Contributor

Goals:
Increasing the Coverage of solandbounds.jl.

Estimated time needed:
2 hours.

@ItamarRocha ItamarRocha added enhancement New feature or request tests labels Mar 25, 2021
@ItamarRocha ItamarRocha self-assigned this Mar 25, 2021
@guimarqu guimarqu removed the enhancement New feature or request label Mar 31, 2021
guimarqu added a commit that referenced this issue Apr 2, 2021
* WIP: covering missing tests in Bounds and Solutions #480 and #479

* fixed refence to Coluna.ColunaBase.getvalue()

* added uncovered cases and get_value

* convert and promote_rule tested

* New tests : iterate, length, setindex, getindex | added function getindex | removed extremum and isapprox in solandbounds.jl

* Base.show methods testes

* added printbounds test and changed printbounds to receive an optional arg named io

* Revised comments regarding unit tests | Updated DynamicSparseArrays version in Project.toml | removed Base.Filter method

* removed julia-1.0.0 in ci.yml

Co-authored-by: Guillaume Marques <[email protected]>
guimarqu added a commit that referenced this issue Apr 5, 2021
* WIP: covering missing tests in Bounds and Solutions #480 and #479

* fixed refence to Coluna.ColunaBase.getvalue()

* added uncovered cases and get_value

* convert and promote_rule tested

* New tests : iterate, length, setindex, getindex | added function getindex | removed extremum and isapprox in solandbounds.jl

* Base.show methods testes

* added printbounds test and changed printbounds to receive an optional arg named io

* Revised comments regarding unit tests | Updated DynamicSparseArrays version in Project.toml | removed Base.Filter method

* removed julia-1.0.0 in ci.yml

* WIP: docstrings draft

* added docstrings and renamed Solution arguments names

* added created docstrings to todo

* Update src/ColunaBase/solsandbounds.jl

Co-authored-by: Guillaume Marques <[email protected]>

* Update src/ColunaBase/solsandbounds.jl

Co-authored-by: Guillaume Marques <[email protected]>

* Update src/ColunaBase/solsandbounds.jl

Co-authored-by: Guillaume Marques <[email protected]>

* Update src/ColunaBase/solsandbounds.jl

Co-authored-by: Guillaume Marques <[email protected]>

* Update src/ColunaBase/solsandbounds.jl

Co-authored-by: Guillaume Marques <[email protected]>

* Update src/ColunaBase/solsandbounds.jl

Co-authored-by: Guillaume Marques <[email protected]>

* Update src/ColunaBase/solsandbounds.jl

Co-authored-by: Guillaume Marques <[email protected]>

* Update src/ColunaBase/solsandbounds.jl

Co-authored-by: Guillaume Marques <[email protected]>

Co-authored-by: Guillaume Marques <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants