feat(x/gov): dynamic deposit throttler #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinDeposit cannot be nil even if not provided because it has a nullable false proto property.
tbruyelle
reviewed
Dec 20, 2024
tbruyelle
reviewed
Jan 10, 2025
| var ( | ||
| depositThresholdMet bool | ||
| thresholds []string | ||
| ) | ||
| for _, minDep := range minDepositAmount { | ||
| for _, minDep := range minDeposit { |
There was a problem hiding this comment.
I realized that while reviewing the min initial deposit PR, and this follows a discussion we had, I think the minDepositRatio should only apply to a fixed value, for example v1.DefaultMinDepositToken (or params.MinDepositThrottler.FloorValue).
I don't think that makes sense to see this value evolving like the min deposit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code for the deposit auto-throttler described in #65