Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(x/gov): move law and amendment proposals to the new v1 system that uses sdk.Msg #20

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

giunatale
Copy link
Collaborator

Changes the law and constitution amendments from being a copy of the legacy text proposal to being compliant with the v1 system based on sdk.Msgs.
The keeper handlers for now do a no-op in both cases.

Since there is no stateful validation possible, the best thing to do for now is to have the law and amendment proposals be empty and let the content be purely in the summary, i.e. same as "text proposals" for gov/v1.

changes the law and constitution amendments from copy of a legacy text proposal to being compliant with the v1 sdk.Msg-based system. The keeper handlers for now do a no-op in both cases
Copy link
Collaborator

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giunatale giunatale merged commit d7bcc46 into main Sep 23, 2024
14 checks passed
@tbruyelle tbruyelle deleted the amendments-laws-sdk-msgs branch December 16, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants